TST replace asert_warns by pytest.warns in compose/tests #19492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#DataUmbrella |
|
cc: @ogrisel @glemaitre |
ogrisel
approved these changes
Feb 27, 2021
ogrisel
reviewed
Feb 27, 2021
|
Apparently a similar pull request has been merged concurrently. I merged master and there remains only a few changes in this PR. |
thomasjpfan
approved these changes
Feb 27, 2021
|
Thank you. It's a pleasure to contribute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#19414
What does this implement/fix? Explain your changes.
Remove the use of assert_warns_message from
test_target.pyincompose/test.Any other comments?
The fix is part of the complete fix for issue #19414