Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC Fix typo in LDA User Guide #19468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Conversation

bdpedigo
Copy link
Contributor

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

"They lie in an affine subspace of dimension at least K-1" should be "at most K-1"
i.e. 3 points must lie in a plane but could lie on a line

Any other comments?

Ref: Elements of Statistical Learning Pg 113

@bdpedigo bdpedigo changed the title Fix typo in LDA docs Fix typo in LDA User Guide Feb 16, 2021
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your neat pick @bdpedigo ! 😉

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bdpedigo

@NicolasHug NicolasHug changed the title Fix typo in LDA User Guide DOC Fix typo in LDA User Guide Feb 17, 2021
@NicolasHug NicolasHug merged commit 4b72b57 into scikit-learn:main Feb 17, 2021
@bdpedigo bdpedigo deleted the patch-1 branch February 17, 2021 13:45
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.