Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

MNT Set non-interactive installation mode for the pypy job #19461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 22, 2021
Merged

MNT Set non-interactive installation mode for the pypy job #19461

merged 10 commits into from
Feb 22, 2021

Conversation

alfaro96
Copy link
Member

@alfaro96 alfaro96 commented Feb 15, 2021 •
edited
Loading

What does this implement/fix? Explain your changes.

This PR fixes the pypy job using non-interactive mode for the installation process (required for tzdata).

@alfaro96 alfaro96 changed the title MNT Fix pypy job MNT Set non-interactive mode for the installation process in pypy job Feb 15, 2021
@alfaro96 alfaro96 changed the title MNT Set non-interactive mode for the installation process in pypy job MNT Set non-interactive installation mode for the process in pypy job Feb 15, 2021
@alfaro96 alfaro96 changed the title MNT Set non-interactive installation mode for the process in pypy job MNT Set non-interactive installation mode for the pypy job Feb 15, 2021
@alfaro96
Copy link
Member Author

The failures in: https://app.circleci.com/pipelines/github/scikit-learn/scikit-learn/11797/workflows/9c81a4ab-b514-475d-8b0d-2c5e7e0e1abf/jobs/132693 seems to be related with numerical precisions errors (further investigation required).

@thomasjpfan
Copy link
Member

To move this forward, we can XFAIL test_kernel_gradient for PYPY and open an issue for it.

thomasjpfan
thomasjpfan approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

.circleci/config.yml Outdated Show resolved Hide resolved
rth
rth approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alfaro96 !

@rth rth merged commit 26c5530 into scikit-learn:main Feb 22, 2021
@alfaro96 alfaro96 deleted the fix_pypy_job branch February 22, 2021 20:33
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@alfaro96 @glemaitre
MNT Set non-interactive installation mode for the pypy job (scikit-le…
da48368 
…arn#19461)
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
@alfaro96 @glemaitre
MNT Set non-interactive installation mode for the pypy job (#19461)
f30629b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:gaussian_process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfaro96 @thomasjpfan @rth
Morty Proxy This is a proxified and sanitized view of the page, visit original site.