-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
ENH Add mean_pinball_loss metric for quantile regression #19415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
468c156
add pinball_error
sdpython 05dca44
fix \r issue
sdpython 367b265
add \r
sdpython d710a6f
add \r
sdpython 72d2d51
remove \r
sdpython 5bc2bc5
fix lint issue
sdpython 621abdd
lint
sdpython 67f3c02
lint
sdpython 789442c
rename pinball_error into pinball_loss
sdpython 076452d
check exception is raised
sdpython 359538e
Fix failing unit test
sdpython 1c2d6d2
refactor example on gradient boosting
sdpython ef64dd0
lint
sdpython 9e56a19
lint
sdpython f07ad17
add dependency on tqdm for examples, fix documentation
sdpython c41f2e3
add new unit test
sdpython 1bdc94e
improve example, add another test on pinball_error with sample_weights
sdpython 0aa34df
lint
sdpython 31d721c
fix failing test due to very small discrepencies
sdpython f8988c7
documentation
sdpython 04e192e
improve example
sdpython 6e787a6
Update plot_gradient_boosting_quantile.py
sdpython e9aa68c
Rework quantile regression example to use skewed noise
ogrisel 94ec164
Typo
ogrisel a7a5aaa
add neg_pinball_loss
sdpython 99d3457
test for more quantiles
sdpython b8d4628
fix wrong change
sdpython fc6e62c
Update _scorer.py
sdpython c3e9431
Phrasing
ogrisel 182b066
Update examples/ensemble/plot_gradient_boosting_quantile.py
ogrisel d5957d1
Tuner hyper-params of quantile regressors
ogrisel cbcd70e
Reduce verbosity, faster example
ogrisel 37d3e93
Restore support for old matplotlib
ogrisel 31915f1
Restore support for old matplotlib (take 2)
ogrisel a258dea
pprint best params to avoid horizontal scroll
ogrisel 95c5709
Update sklearn/metrics/_regression.py
ogrisel f343f3f
More comprehensive test for the pinball loss with constant predictions
ogrisel 9958903
Skip new test on old numpy
ogrisel 0fa7e10
Expand documentation to present scorer API for quantile regression
ogrisel 22d56b7
Use heteroschedastic noise
ogrisel 619c138
More intuitive examples for pinball_loss
ogrisel 50a65f0
Even more explicit examples
ogrisel 1e5ff82
remove neg_pinball_loss, update what's new
sdpython 3c1161a
remove unnecessary import in _scorer.py
sdpython e6687f6
Further improve example
ogrisel 7f1c249
Update examples/ensemble/plot_gradient_boosting_quantile.py
ogrisel bf2033f
Small fix + mention biais of LAD as a (robust) estimator of the mean
ogrisel 070cbab
Assess coverage
ogrisel ecf1a95
Apply suggestions from code review
ogrisel 4ce9196
Stricter tests for regression metrics
ogrisel 1b2d0ed
Minimize pinball loss with Nelder-Mead
ogrisel f6482e6
Small fixes and improvements in model_evaluation.rst
ogrisel bc1882a
Rename variable in test
ogrisel 53e0230
Rename pinball_loss to mean_pinball_loss
ogrisel 6694b1f
Fix linter
ogrisel d139dc2
Fix missing indent in math formula
ogrisel 728d632
Fix phrasing
ogrisel eb22059
Add integration test
ogrisel 8edbed1
Change optimization test to make it run faster
ogrisel 1b36537
Missing cell marker
ogrisel 85ab9d3
Missing comas
ogrisel 70d9323
DOC small improvements
ogrisel 7820618
Update sklearn/metrics/tests/test_regression.py
ogrisel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.