Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

TST replace assert_raise_* by pytest.raises in ensemble module #19399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 11, 2021

Conversation

halsawadi
Copy link
Contributor

Co-authored-by: @feras-oughali
Reference Issues/PRs

This PR is related to issue #14216
What does this implement/fix? Explain your changes.

Change assert_raises and assert_raises_regex to :

with pytest.raises(.....)

This is a part of Data Umbrella's sprint that was held in February 2021.

@Mariam-ke
Copy link
Contributor

#DataUmbrella sprint
cc: @reshamas

hassanalsawadi and others added 4 commits February 10, 2021 14:32
Co-authored-by: feras-oughali <oughali.feras@gmail.com>
Co-authored-by: feras-oughali <oughali.feras@gmail.com>
Co-authored-by: feras-oughali <oughali.feras@gmail.com>
@glemaitre glemaitre self-requested a review February 11, 2021 10:13
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I solve the conflict with the main branch after having merge some other PRs.

@jeremiedbb Do you want to have a look at this one.

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @halsawadi and @feras-oughali!

@rth rth merged commit c61dcff into scikit-learn:main Feb 11, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.