-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
TST replace assert_raise_* by pytest.raises in ensemble module #19399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: feras-oughali <oughali.feras@gmail.com>
…nto fix_assert_raises
#DataUmbrella sprint |
…nto fix_assert_raises
Co-authored-by: feras-oughali <oughali.feras@gmail.com>
Co-authored-by: feras-oughali <oughali.feras@gmail.com>
Co-authored-by: feras-oughali <oughali.feras@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I solve the conflict with the main
branch after having merge some other PRs.
@jeremiedbb Do you want to have a look at this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @halsawadi and @feras-oughali!
Co-authored-by: @feras-oughali
Reference Issues/PRs
This PR is related to issue #14216
What does this implement/fix? Explain your changes.
Change assert_raises and assert_raises_regex to :
with pytest.raises(.....)
This is a part of Data Umbrella's sprint that was held in February 2021.