Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

TST replace assert_raises* by pytest.raises in dummy module #19386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 7, 2021
Merged

TST replace assert_raises* by pytest.raises in dummy module #19386

merged 4 commits into from
Feb 7, 2021

Conversation

isaacknjama
Copy link
Contributor

@isaacknjama isaacknjama commented Feb 6, 2021 •
edited by lorentzenchr
Loading

Reference Issues/PRs

Towards #14216. Also closes #19382.

What does this implement/fix? Explain your changes.

Update the 'return a tolerance which is independent of the database' to 'return a tolerance which is dependent on the database.

@reshamas
Copy link
Member

reshamas commented Feb 6, 2021

#DataUmbrella sprint
cc: @Mariam-ke

@lorentzenchr lorentzenchr changed the title Dependent tolerance comment MAINT replace assert_raises* by pytest.raise in sklearn/tests/test_dummy.py Feb 6, 2021
@lorentzenchr
Copy link
Member

@icky254 I updated the title as, in principle, this could have been divided in 2 separate PRs. The title now reflects the large change.

lorentzenchr
lorentzenchr approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre glemaitre changed the title MAINT replace assert_raises* by pytest.raise in sklearn/tests/test_dummy.py TST replace assert_raises* by pytest.raise in dummy module Feb 7, 2021
@glemaitre glemaitre changed the title TST replace assert_raises* by pytest.raise in dummy module TST replace assert_raises* by pytest.raises in dummy module Feb 7, 2021
@glemaitre glemaitre self-requested a review February 7, 2021 10:12
@glemaitre glemaitre merged commit e230778 into scikit-learn:main Feb 7, 2021
@glemaitre
Copy link
Member

thanks @icky254

@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorentzenchr lorentzenchr lorentzenchr approved these changes

@glemaitre glemaitre Awaiting requested review from glemaitre

Assignees
No one assigned
Labels
module:cluster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong comment for function _tolerance(X, tol) in cluster/_kmeans.py
4 participants
@isaacknjama @reshamas @lorentzenchr @glemaitre
Morty Proxy This is a proxified and sanitized view of the page, visit original site.