EXA improve example of forest feature importances #19377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glemaitre as we reviewed during the sprint. |
|
#DataUmbrella sprint |
|
@azihna I made a push on your fork to solve the issue regarding the section. I will wait for the rendering. Feel free to make a new review in case I made some mistakes when pushing. |
|
Thanks @azihna for checking the spelling. The rendering is OK so I will merge this PR. |
|
Thanks a lot for your great support @glemaitre and thanks to @reshamas for arranging the sprint. It was a great learning experience! |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
Co-authored-by: Alihan Zihna <a.zihna@ckhgbdp.onmicrosoft.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
that referenced
this pull request
Apr 28, 2021
Co-authored-by: Alihan Zihna <a.zihna@ckhgbdp.onmicrosoft.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
References #14528
Done on the sprint together with @temmyzeus
What does this implement/fix? Explain your changes.
Add the new examples using permutation importance and convert the existing code sample to the new Sphinx structure.