TST replace assert_raises with the pytest.raises context manager in dummy module #19372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#DataUmbrella sprint |
lorentzenchr
reviewed
Feb 6, 2021
sklearn/tests/test_dummy.py
Outdated
|
|
||
| est = DummyRegressor(strategy="quantile", quantile='abc') | ||
| assert_raises(TypeError, est.fit, X, y) | ||
| with pytest.raises(ValueError): |
There was a problem hiding this comment.
Suggested change
| with pytest.raises(ValueError): | |
| with pytest.raises(TypeError): |
There was a problem hiding this comment.
Optionally, the whole test could be parameterizes as:
@pytest.mark.parametrize(
"quantile, error",
[
("default", ValueError),
(None, ValueError),
# TODO: Fill in the futher cases here
],
)
def test_quantile_invalid(quantile, error):
X = [[0]] * 5 # ignored
y = [0] * 5 # ignored
if quantile == "default":
est = DummyRegressor(strategy="quantile")
else:
est = DummyRegressor(strategy="quantile", quantile=quantile)
with pytest.raises(ValueError):
est.fit(X, y)There was a problem hiding this comment.
I am not sure parametrization helps with readability in this case.
lorentzenchr
approved these changes
Feb 6, 2021
|
Thanks @icky254 Good to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #14216
What does this implement/fix? Explain your changes.
Replaced assert_raises with the pytest context manager.
Any other comments?
Pair programming partner @marenwestermann