Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

MAINT replace assert_raises* by pytest.raise in model_selection/tests/test_search #19371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mohaseeb
Copy link
Contributor

@mohaseeb mohaseeb commented Feb 6, 2021

Reference Issues/PRs

References #14216

What does this implement/fix? Explain your changes.

Removes the use of assert_raises* in model_selection/tests/test_search.py

Any other comments?

cc: (pair programming partner) @cycks

@reshamas
Copy link
Member

reshamas commented Feb 6, 2021

#DataUmbrella sprint

@glemaitre glemaitre changed the title MAINT Remove the use of assert_raises* in model_selection/tests/test_search MAINT replace assert_raises* by pytest.raise in model_selection/tests/test_search Feb 6, 2021
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Let see if the CIs will not catch anything that I would have miss.

Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge when CI shows green light.

@lorentzenchr lorentzenchr merged commit a952fbb into scikit-learn:main Feb 6, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.