Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

ENH Adds categories with missing values support to fetch_openml with as_frame=True #19365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 6, 2021
Merged

ENH Adds categories with missing values support to fetch_openml with as_frame=True #19365

merged 10 commits into from
Feb 6, 2021

Conversation

amy12xx
Copy link
Contributor

@amy12xx amy12xx commented Feb 6, 2021

Fixes #18383
Supersedes #18383

Enables using the categorical dtype for features with missing values.

doc/whats_new/v0.24.rst Outdated Show resolved Hide resolved
@glemaitre glemaitre changed the title Openml pandas cat missing vals ENH Adds categories with missing values support to fetch_openml with as_frame=True Feb 6, 2021
doc/whats_new/v0.24.rst Outdated Show resolved Hide resolved
doc/whats_new/v0.24.rst Outdated Show resolved Hide resolved
@glemaitre glemaitre self-requested a review February 6, 2021 08:10
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart of those LGTM

@reshamas
Copy link
Member

reshamas commented Feb 6, 2021

#DataUmbrella sprint

doc/whats_new/v0.24.rst Show resolved Hide resolved
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then

@adrinjalali adrinjalali merged commit 80c47b0 into scikit-learn:main Feb 6, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.