-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
CI Update ICC install commands #19329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jeremiedbb!
LGTM, although the documentation tests are not passing, it seems to be unrelated with this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looking at the code, the unrelated error looks strange.
Yes I can't figure out what's going on... But actually let me try to move the icc build to azure pipelines, we'll if it still fails there. It should be done eventually anyway. |
ok looks good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving to azure is even better! Thank you @jeremiedbb :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
||
.. prompt:: bash $ | ||
|
||
sudo apt-get install intel-oneapi-icc | ||
sudo apt-get install intel-oneapi-compiler-dpcpp-cpp-and-cpp-classic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They decided that one (or even two) cpp
in the name was not explicit enough to indicate that it compiled C++ ?
intel oneapi is now officially released and the names of some packages have changed