Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

CI Update ICC install commands #19329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 3, 2021

Conversation

jeremiedbb
Copy link
Member

intel oneapi is now officially released and the names of some packages have changed

@ogrisel ogrisel changed the title [WIP] Update ICC install commands CI [WIP] Update ICC install commands Feb 2, 2021
@jeremiedbb jeremiedbb changed the title CI [WIP] Update ICC install commands CI Update ICC install commands Feb 2, 2021
Copy link
Member

@alfaro96 alfaro96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jeremiedbb!

LGTM, although the documentation tests are not passing, it seems to be unrelated with this PR.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looking at the code, the unrelated error looks strange.

@jeremiedbb
Copy link
Member Author

Looking at the code, the unrelated error looks strange.

Yes I can't figure out what's going on... But actually let me try to move the icc build to azure pipelines, we'll if it still fails there. It should be done eventually anyway.

@jeremiedbb
Copy link
Member Author

ok looks good now.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to azure is even better! Thank you @jeremiedbb :)

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


.. prompt:: bash $

sudo apt-get install intel-oneapi-icc
sudo apt-get install intel-oneapi-compiler-dpcpp-cpp-and-cpp-classic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They decided that one (or even two) cpp in the name was not explicit enough to indicate that it compiled C++ ?

@rth rth merged commit d831bab into scikit-learn:main Feb 3, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.