Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC Minor adjustments to clarify docstrings + fixes links to references #19282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

thomasjpfan
Copy link
Member

This PR has minor adjustments to clarify docstrings and fixes links to references in LocallyLinearEmbedding

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the weird the fact of setting the default value by importing it from another module but let's ignore that for now :)

LGTM. Maybe just add some punctuation (comments below).

sklearn/manifold/_locally_linear.py Outdated Show resolved Hide resolved
sklearn/manifold/_locally_linear.py Outdated Show resolved Hide resolved
sklearn/manifold/_locally_linear.py Outdated Show resolved Hide resolved
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
@jeremiedbb
Copy link
Member

thanks @thomasjpfan

@jeremiedbb jeremiedbb merged commit c86076f into scikit-learn:main Jan 27, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.