Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC: update Keras description in related projects #19265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2021

Conversation

adriangb
Copy link
Contributor

This updates the description for Keras because:

  • It is now hosted as part of TensorFlow (hence why I linked to the docs and not the repo, which might be confusing).
  • It no longer runs on Theano.

rth
rth previously approved these changes Jan 25, 2021
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adriangb!

@@ -148,8 +148,8 @@ and tasks.
- `nolearn <https://github.com/dnouri/nolearn>`_ A number of wrappers and
abstractions around existing neural network libraries

- `keras <https://github.com/fchollet/keras>`_ Deep Learning library capable of
running on top of either TensorFlow or Theano.
- `Keras <https://www.tensorflow.org/api_docs/python/tf/keras>`_ High-level API for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there is now https://github.com/keras-team/keras so maybe this will change in the near future. Also I'm not sure about "scikit-learn inspired API" part. There are certainly some inspiration, but the API is generally not compatiblke with scikit-learn without tf.keras.wrappers.scikit_learn wrappers.

Copy link
Contributor Author

@adriangb adriangb Jan 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is their old repository, which may be used again at some point, but it is unclear when. For now I think the best place to link is the docs.

Happy to change the description if you have any other suggestions. The Keras authors have stated that it was inspired by sklearn, and it's certainly closer than pure Pytorch (not that that's a fair comparison). The intention is to suggest "familiar" not "drop in compatible".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fair enough. Thanks!

@rth rth dismissed their stale review January 25, 2021 08:35

pending comments

@rth rth merged commit 315463f into scikit-learn:main Jan 26, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.