-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC: update Keras description in related projects #19265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adriangb!
@@ -148,8 +148,8 @@ and tasks. | ||
- `nolearn <https://github.com/dnouri/nolearn>`_ A number of wrappers and | ||
abstractions around existing neural network libraries | ||
|
||
- `keras <https://github.com/fchollet/keras>`_ Deep Learning library capable of | ||
running on top of either TensorFlow or Theano. | ||
- `Keras <https://www.tensorflow.org/api_docs/python/tf/keras>`_ High-level API for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually there is now https://github.com/keras-team/keras so maybe this will change in the near future. Also I'm not sure about "scikit-learn inspired API" part. There are certainly some inspiration, but the API is generally not compatiblke with scikit-learn without tf.keras.wrappers.scikit_learn
wrappers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is their old repository, which may be used again at some point, but it is unclear when. For now I think the best place to link is the docs.
Happy to change the description if you have any other suggestions. The Keras authors have stated that it was inspired by sklearn, and it's certainly closer than pure Pytorch (not that that's a fair comparison). The intention is to suggest "familiar" not "drop in compatible".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, fair enough. Thanks!
This updates the description for Keras because: