Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC Updates css consistent admonition styling #19249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

thomasjpfan
Copy link
Member

This PR gives more style to versionadded:

Screen Shot 2021-01-22 at 3 50 24 PM

Also some refactoring so all of these admonitions have the same rounded look.

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks pretty good :)

@rth
Copy link
Member

rth commented Jan 24, 2021

+1 for color highlights in deprecated, however I'm not sure sure about versionadded,

image

Here the versionchanged becomes the most highlighted part of this method while it shouldn't matter for most users assuming they have a recent enough version of scikit-learn. As times goes by most versionchanged will be for fairly old versions. So in that sense putting colors there can be distracting from actually relevant information in the API docs. IMO just italics was fine, and an appropriate level of highlighting.

@thomasjpfan thomasjpfan changed the title DOC Updates css for hightlighting new items DOC Updates css consistent admonition styling Jan 24, 2021
@thomasjpfan
Copy link
Member Author

Hm that make sense, I removed the versionadded coloring so this PR is just a minor refactor. This PR now makes the admonitions more consistent style-wise.

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rth rth merged commit 8815bce into scikit-learn:main Feb 1, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.