Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[DOC] Clarify the docstring of dict learning about the inits #19227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2021

Conversation

jeremiedbb
Copy link
Member

@jeremiedbb jeremiedbb commented Jan 21, 2021

Fixes #9081

The dict_init and code_init params are only used if both are provided.
SparsePCA uses dict_learning so it needs clarification too.

sklearn/decomposition/_dict_learning.py Outdated Show resolved Hide resolved
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from master to main January 22, 2021 10:53
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It seams "dict_learning" doesn't use the "code_init" param at all
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.