Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC Add scikeras to related projects. #19226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

cmarmo
Copy link
Contributor

@cmarmo cmarmo commented Jan 21, 2021

What does this implement/fix? Explain your changes.

The scikit-learn wrappers are definitely deprecated in tensorflow (see comment in tensorflow#37201).
They are now maintained in an autonomous project scikeras.

I have added scikeras to the "related projects" page in the documentation.

Any other comments?

I couldn't find a better solution than adding it in 'data format'... :( I'm open to suggestions.

doc/related_projects.rst Outdated Show resolved Hide resolved
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @cmarmo

@jeremiedbb jeremiedbb merged commit 4db51e6 into scikit-learn:master Jan 21, 2021
@cmarmo cmarmo deleted the scikeras-doc branch January 22, 2021 17:58
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.