Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

kernel pca doc additions #19201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from
Open

kernel pca doc additions #19201

wants to merge 1 commit into from

Conversation

Asami-1
Copy link

@Asami-1 Asami-1 commented Jan 18, 2021

Reference Issues/PRs

Answers #17171

What does this implement/fix? Explain your changes.

Added details on the Kernel PCA method documentation to clarify any misunderstandings about the shapes of
the objects manipulated.

Any other comments?

I went with doc/images folder to add an image but I'm not sure it was the right place to put it. Please check and confirm it's OK.

@ArturoAmorQ
Copy link
Member

Thanks for contributing @Asami-1! A first general comments regarding your PR:

In general we try to avoid introducing external images to the documentation, instead we prefer adding references to existing images from the example gallery. In this way people can access the code that generated a given image and reproduce it or play with variants of it.

My suggestion is then to either:

a) create a similar image within the narrative of the Kernel PCA example (maybe you can use this example as inspiration);

b) try to pass the same message as in the current state of this PR but using the images in this example without the need of reworking it.

A smaller remark: try to keep a maximum line lenght of 79 characters to follow the PEP 8 convention. That will make the work easier for the reviewers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.