MAINT Add @fails_if_pypy to test_nonnegative_hashing_vectorizer_result_indices #19173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need a backport in the 0.24.X branch to make it possible to release the PyPy artifacts for 0.24.1 on conda-forge. |
|
There is no commit message marker to try it on the circle ci pypy job as part of this PR, so merging directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got a nightly build failure on circle ci for the PyPy job because of a new test for
HashingVectorizerthat raisesNotImplementedError.Details:
https://app.circleci.com/pipelines/github/scikit-learn/scikit-learn/10754/workflows/229b09b0-27fd-41dc-840f-c96c910a8c07/jobs/129460