Dictionary Learning: transform_alpha default equal to alpha #19159
+37
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Jan 18, 2021
There was a problem hiding this comment.
thanks @bmalezieux. Please update the title of the PR to better reflect the changes
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
jeremiedbb
reviewed
Jan 21, 2021
jeremiedbb
reviewed
Jan 25, 2021
There was a problem hiding this comment.
There are tests failing because we change future warnings into errors in our test suite. We need to set transform_alpha in the failing tests.
Note that first let's only issue the warning when alpha !=1 (see comment below). This should significantly reduce the number of failing tests.
jeremiedbb
approved these changes
Jan 26, 2021
rth
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ctionaryLearning
Reference Issues/PRs
Fixes #19154
What does this implement/fix? Explain your changes.
Setting the default value of transform_alpha to alpha in order to avoid confusion.
Any other comments?