MNT better error message in RidgeCV #19020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it more clear that alphas of zero are not allowed.
glemaitre
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
LGTM.
Thanks @brianrice2
Let's wait for a second review before merging the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #18994
What does this implement/fix? Explain your changes.
Since alphas of zero are disallowed, this adds (a word) to the error message to specify that alphas must be strictly positive.
Any other comments?
Includes a commit for updates to two tests which were expecting the previous error message (no "strictly").