Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

BLD Add clean command to skip list #18999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

alfaro96
Copy link
Member

Reference Issues/PRs

Address one of the items in #18977.

What does this implement/fix? Explain your changes.

This PR adds the check command to the list of commands that do not require numpy to succeed.

Any other comments?

CC @ogrisel and @thomasjpfan.

@glemaitre glemaitre self-requested a review December 14, 2020 15:30
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@glemaitre glemaitre merged commit d953f74 into scikit-learn:master Dec 14, 2020
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alfaro96 alfaro96 deleted the add_clean_command branch December 14, 2020 15:40
@ogrisel
Copy link
Member

ogrisel commented Dec 14, 2020

To be backported in 0.24.X.

@ogrisel ogrisel added this to the 0.24 milestone Dec 14, 2020
@ogrisel ogrisel added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Dec 16, 2020
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 22, 2020
@glemaitre glemaitre mentioned this pull request Dec 22, 2020
14 tasks
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.