Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC Fixing citations for de Leeuw in isotonic.py #18952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

nfultz
Copy link
Contributor

@nfultz nfultz commented Dec 1, 2020

What does this implement/fix? Explain your changes.

Usually I have seen J de Leeuw cited as de Leeuw (with the de).

See for example the citation at https://link.springer.com/article/10.1007/BF02293750#citeas

Any other comments?

@deleeuw is this right?

This is not urgent to me but thought I should mention it.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @nfultz !

In this case, I think following the recommendation from Springer makes sense.

@thomasjpfan thomasjpfan changed the title isotonic.py: Fixing citations for de Leeuw DOC Fixing citations for de Leeuw in isotonic.py Dec 3, 2020
@glemaitre glemaitre merged commit 38b7155 into scikit-learn:master Dec 16, 2020
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 22, 2020
)

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@glemaitre glemaitre mentioned this pull request Dec 22, 2020
14 tasks
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
)

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.