Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[MRG] Use check_finite=False in sklearn.manifold #18886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 3, 2021
Merged

[MRG] Use check_finite=False in sklearn.manifold #18886

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bbb34f2
Use_check_finite=False for the call to svd (hessian)
jjerphan Nov 20, 2020
751376a
Use_check_finite=False for the call to eigh (hessian)
jjerphan Nov 20, 2020
b6e5ff1
Use_check_finite=False for the call to qr
jjerphan Nov 20, 2020
f76dae7
Use_check_finite=False for the call to solve
jjerphan Nov 20, 2020
57f1afa
Use_check_finite=False for the call to svd (modified)
jjerphan Nov 20, 2020
93c5d86
Use_check_finite=False for the call to eigh (modified)
jjerphan Nov 20, 2020
be3f492
Use_check_finite=False for the call to svd (ltsa)
jjerphan Nov 20, 2020
ba7cd8b
Use_check_finite=False for the call to eigh (ltsa)
jjerphan Nov 20, 2020
50621ed
Use_check_finite=False for the call to eigh
jjerphan Nov 23, 2020
e949029
Revert check_finite to True for solve
jjerphan Dec 12, 2020
b2aeaba
Revert check_finite to True for qr
jjerphan Dec 12, 2020
b8fc12c
Revert check_finite to True for potential non-finiteness
jjerphan Dec 22, 2020
9c60bcf
Merge remote-tracking branch 'upstream/main' into duplicate_finite_ch…
rth Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 sklearn/manifold/_spectral_embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ def spectral_embedding(adjacency, *, n_components=8, eigen_solver=None,
# lobpcg will fallback to eigh, so we short circuit it
if sparse.isspmatrix(laplacian):
laplacian = laplacian.toarray()
_, diffusion_map = eigh(laplacian)
_, diffusion_map = eigh(laplacian, check_finite=False)
jjerphan marked this conversation as resolved.
Show resolved Hide resolved
embedding = diffusion_map.T[:n_components]
if norm_laplacian:
embedding = embedding / dd
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.