DOC Add var_ attribute and deprecate sigma_ in GaussianNB #18842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathschy
approved these changes
Nov 16, 2020
glemaitre
reviewed
Dec 19, 2020
|
Which version should the whatsnew be in? |
|
`1.0.rst`. You might need to merge master into your branch.
…On Mon, 21 Dec 2020 at 12:12, Shao Yang Hong ***@***.***> wrote:
Which version should the whatsnew be in?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#18842 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABY32P3DDXHR2QHONQU5N5LSV4URTANCNFSM4TWBO2VQ>
.
--
Guillaume Lemaitre
Scikit-learn @ Inria Foundation
https://glemaitre.github.io/
|
jeremiedbb
reviewed
Dec 22, 2020
jeremiedbb
reviewed
Dec 22, 2020
jeremiedbb
reviewed
Dec 22, 2020
…deprecatesigma # Conflicts: # doc/whats_new/v1.0.rst
jeremiedbb
approved these changes
Dec 23, 2020
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
glemaitre
reviewed
Jan 4, 2021
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
|
@glemaitre Whatsnew has been added. Code changes applied. |
|
I just solved the conflict in whats new. Merging. Thanks @hongshaoyang |
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #16760
What does this implement/fix? Explain your changes.
sigmameans std deviation which is confusing asGaussianNB.sigma_is currently the variance of each feature per classRename sigma_ to var_ and deprecate sigma_
Any other comments?