-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC use notebook style and diagram for feature selection example #18836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
glemaitre
merged 5 commits into
scikit-learn:main
from
glemaitre:improve_example_feature_selection
Jan 28, 2021
Merged
DOC use notebook style and diagram for feature selection example #18836
glemaitre
merged 5 commits into
scikit-learn:main
from
glemaitre:improve_example_feature_selection
Jan 28, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Nov 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @glemaitre for working on the examples!
TomDLT
approved these changes
Jan 27, 2021
thomasjpfan
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment about formatting, otherwise LGTM
I checked the output and this is good to go. |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
glemaitre
added a commit
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use notebook style and use the diagram to illustrate what is a pipeline.