Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC use pipeline in example using RF, RT, GBDT for feature engineering #18835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

glemaitre
Copy link
Member

Modify the example to use some Pipeline and change it to a notebook style example.

examples/ensemble/plot_feature_transformation.py Outdated Show resolved Hide resolved
examples/ensemble/plot_feature_transformation.py Outdated Show resolved Hide resolved
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise LGTM.

Side note: this feels like stacking where we use apply instead of predict.

examples/ensemble/plot_feature_transformation.py Outdated Show resolved Hide resolved
examples/ensemble/plot_feature_transformation.py Outdated Show resolved Hide resolved
examples/ensemble/plot_feature_transformation.py Outdated Show resolved Hide resolved
glemaitre and others added 2 commits January 11, 2021 19:12
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Base automatically changed from master to main January 22, 2021 10:53
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's clearly a non trivial example and a nice code improvement. Thanks!

@rth rth merged commit 69d6378 into scikit-learn:main Feb 1, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
glemaitre added a commit that referenced this pull request Apr 28, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.