DOC use diagram and simplify pipeline in stacking example #18830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
reviewed
Nov 20, 2020
| for cat in categories: | ||
| cat[cat == None] = 'missing' # noqa | ||
| tree_preprocessor = make_column_transformer( | ||
| (num_tree_processor, num_cols), |
There was a problem hiding this comment.
why not cat_selector and num_selector here?
There was a problem hiding this comment.
I illustrated l.90 that it gives the columns name and reuse the columns then.
There was a problem hiding this comment.
fair, but it would also be nice to show off the callable option which I don't think many people know about... I could go either way on this one though.
thomasjpfan
reviewed
Nov 24, 2020
| for cat in categories: | ||
| cat[cat == None] = 'missing' # noqa | ||
| tree_preprocessor = make_column_transformer( | ||
| (num_tree_processor, num_cols), |
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
approved these changes
Jan 28, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
rth
approved these changes
Feb 1, 2021
rth
reviewed
Feb 1, 2021
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
…rn#18830) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
glemaitre
added a commit
that referenced
this pull request
Apr 28, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the stacking example by showing the different pipelines with diagrams.
In addition, we do not list the categories beforehand in the
OrdinalEncoderto use the new feature of a rare category.Besides, we let the encoder treat
np.nanas a separate category without imputing a new string.