[MRG] Better error messages for bad contamination in outlier detectors #18780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Dec 22, 2020
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
rth
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
Not a specialist but the suggested change sounds reasonable.
Same for me. Thanks @albertcthomas !
|
The CircleCI lint failed with, but I just merged master, so I'm going to ignore it and hope it will be OK once merged. The Azure pipeline lint passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong contamination values for
EllipticEnvelopeandIsolationForestwere not returning an appropriateValueErroras is the case forLocalOutlierFactor.I also improved the common tests to catch this.