ENH Adds n_features_in_ checks to impute module #18580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Oct 12, 2020
sklearn/impute/_iterative.py
Outdated
| @@ -474,7 +474,7 @@ def _get_abs_corr_mat(self, X_filled, tolerance=1e-6): | ||
| abs_corr_mat = normalize(abs_corr_mat, norm='l1', axis=0, copy=False) | ||
| return abs_corr_mat | ||
|
|
||
| def _initial_imputation(self, X): | ||
| def _initial_imputation(self, X, in_fit=True): |
There was a problem hiding this comment.
I would find it safer to set in_fit=False as the default value and only set it to true when called in the fit method instead of having to explicitly set it to False anywhere else. WDYT?
There was a problem hiding this comment.
Agreed. PR updated with this change.
amueller
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Continues #18514