[MRG] Make drop_idx_ a masked array in OneHotEncoder
#16554
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry... I forgot to finish the tests... :( |
drop_idx_ a masked array in OneHotEncoderdrop_idx_ a masked array in OneHotEncoder
drop_idx_ a masked array in OneHotEncoderdrop_idx_ a masked array in OneHotEncoder
|
I am not sure that we should use a mask array. If it was only some internal issues without exposing the resulting array, I think that it will be OK because we already use this mask array in the I would think this is more friendly to have a list or a NumPy array with object dtype where we model with None or the index to be dropped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #16552.
What does this implement/fix? Explain your changes.
Make
drop_idx_a numpy masked array in order to manage column selection.