TST: Fix assert raises in sklearn/metrics/tests/
#14715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to #14216
glemaitre
requested changes
Aug 23, 2019
glemaitre
reviewed
Aug 23, 2019
sklearn/metrics/tests/test_common.py
Outdated
| @@ -556,7 +555,7 @@ def test_not_symmetric_metric(name): | ||
| metric = ALL_METRICS[name] | ||
|
|
||
| # use context manager to supply custom error message | ||
| with assert_raises(AssertionError) as cm: | ||
| with pytest.raises(AssertionError) as cm: |
There was a problem hiding this comment.
This will not work as intended with pytest.
I think that we want something like this instead
with pytest.raises(AssertionError):
assert_array_equal(metric(y_true, y_pred), metric(y_pred, y_true))
raise ValueError("%s seems to be symmetric:" %name)There was a problem hiding this comment.
@glemaitre Thanks for pointing that out! Will make the required change.
glemaitre
reviewed
Aug 23, 2019
sklearn/metrics/tests/test_common.py
Outdated
| @@ -1140,7 +1152,7 @@ def check_sample_weight_invariance(name, metric, y1, y2): | ||
| weighted_score = metric(y1, y2, sample_weight=sample_weight) | ||
|
|
||
| # use context manager to supply custom error message | ||
| with assert_raises(AssertionError) as cm: | ||
| with pytest.raises(AssertionError) as cm: |
There was a problem hiding this comment.
This is the same issue than above. You need to raise a ValueError within the context manager.
glemaitre
reviewed
Aug 23, 2019
| assert_raises_regex(ValueError, "Mean Squared Logarithmic Error cannot be " | ||
| "used when targets contain negative values.", | ||
| mean_squared_log_error, [1., -2., 3.], [1., 2., 3.]) | ||
| with pytest.raises(ValueError, match="Mean Squared Logarithmic Error " |
There was a problem hiding this comment.
You can move the message out of raises
glemaitre
previously requested changes
Aug 23, 2019
|
@rth. I have made the required changes. You can have a look. |
|
@rth I have removed all except one instances of |
|
@thomasjpfan Can you have a look? |
rth
approved these changes
Sep 8, 2019
sklearn/metrics/tests/sklearn/metrics/tests/
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced
assert_raisesandassert_raises_regexwithpytest.raisescontext manager.related to #14216