Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

MAINT:Fix assert raises in sklearn/compose/tests/ #14670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2019
Merged

MAINT:Fix assert raises in sklearn/compose/tests/ #14670

merged 3 commits into from
Aug 17, 2019

Conversation

sameshl
Copy link
Contributor

@sameshl sameshl commented Aug 16, 2019

replaced assert_raises and assert_raises_regex with pytest.raises context manager.

related to #14216

replaced `assert_raises` and `assert_raises_regex` with
the with `pytest.raises` context manager.

related to #14216
@thomasjpfan
Copy link
Member

Run the following to see the lint errors locally:

make flake8-diff

@thomasjpfan thomasjpfan merged commit db23c4e into scikit-learn:master Aug 17, 2019
@thomasjpfan
Copy link
Member

Thank you @sameshl!

@sameshl sameshl deleted the compose_tests branch August 17, 2019 09:32
@sameshl
Copy link
Contributor Author

sameshl commented Aug 17, 2019

Thank you @thomasjpfan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.