Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

RFC Consistency for meta infos in files (license, encoding, authors, ..) #20813

Copy link
Copy link
Closed
@lorentzenchr

Description

@lorentzenchr
Issue body actions

There are several pieces of information that some files contain, others do not, examples are:

  • # -*- coding: utf-8 -*- at the beginning of a file
  • License information, eg # License: BSD 3 clause
  • List of (some main) authors for that file, # Authors:

For the following reasons, I'd like to remove the encoding info, and have a consistent policy for the other 2 points:

  • As a (newish) contributor, it's hard to figure out what is expected.
  • Having those infos consistent in all files might help a tiny little bit to generate trust in the production-readiness of scikit-learn.

I haven't figured out a convincing policy for authors, maybe leave it as is.

Note that changes of those lines of code shouldn't produce merge conflicts, cross referencing #11336.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.