Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Inconsistency between predict and predict_proba parameters in Pipeline #12006

Copy link
Copy link
Open
@Noctiphobia

Description

@Noctiphobia
Issue body actions

Pull request #9304 fixed issue #9293 by adding **predict_params to predict method of Pipeline, but predict_proba was not changed and still only takes one parameter. I don't see why predict_proba (and also predict_log_proba) shouldn't also be updated in the same fashion, but I may be missing something.
Also as a related change, fit_predict also has this inconsistency, but in this case it's harder to do as cleanly (as there is already **fit_params passed as kwargs) - but maybe adding predict_params just as a normal, optional dict would be justified?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.