Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c00c4bd

Browse filesBrowse files
azihnaAlihan Zihna
and
Alihan Zihna
authored
Change assert_raises to pytest_raises (#19509)
Co-authored-by: Alihan Zihna <a.zihna@ckhgbdp.onmicrosoft.com>
1 parent 15c2c72 commit c00c4bd
Copy full SHA for c00c4bd

File tree

3 files changed

+19
-17
lines changed
Filter options

3 files changed

+19
-17
lines changed

‎sklearn/tests/test_calibration.py

Copy file name to clipboardExpand all lines: sklearn/tests/test_calibration.py
+9-8Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
from sklearn.utils._testing import (assert_array_almost_equal,
1414
assert_almost_equal,
1515
assert_array_equal,
16-
assert_raises, ignore_warnings)
16+
ignore_warnings)
1717
from sklearn.utils.extmath import softmax
1818
from sklearn.exceptions import NotFittedError
1919
from sklearn.datasets import make_classification, make_blobs
@@ -60,7 +60,8 @@ def test_calibration(data, method, ensemble):
6060
prob_pos_clf = clf.predict_proba(X_test)[:, 1]
6161

6262
cal_clf = CalibratedClassifierCV(clf, cv=y.size + 1, ensemble=ensemble)
63-
assert_raises(ValueError, cal_clf.fit, X, y)
63+
with pytest.raises(ValueError):
64+
cal_clf.fit(X, y)
6465

6566
# Naive Bayes with calibration
6667
for this_X_train, this_X_test in [(X_train, X_test),
@@ -386,8 +387,8 @@ def test_sigmoid_calibration():
386387

387388
# check that _SigmoidCalibration().fit only accepts 1d array or 2d column
388389
# arrays
389-
assert_raises(ValueError, _SigmoidCalibration().fit,
390-
np.vstack((exF, exF)), exY)
390+
with pytest.raises(ValueError):
391+
_SigmoidCalibration().fit(np.vstack((exF, exF)), exY)
391392

392393

393394
def test_calibration_curve():
@@ -406,8 +407,8 @@ def test_calibration_curve():
406407

407408
# probabilities outside [0, 1] should not be accepted when normalize
408409
# is set to False
409-
assert_raises(ValueError, calibration_curve, [1.1], [-0.1],
410-
normalize=False)
410+
with pytest.raises(ValueError):
411+
calibration_curve([1.1], [-0.1], normalize=False)
411412

412413
# test that quantiles work as expected
413414
y_true2 = np.array([0, 0, 0, 0, 1, 1])
@@ -421,8 +422,8 @@ def test_calibration_curve():
421422
assert_almost_equal(prob_pred_quantile, [0.1, 0.8])
422423

423424
# Check that error is raised when invalid strategy is selected
424-
assert_raises(ValueError, calibration_curve, y_true2, y_pred2,
425-
strategy='percentile')
425+
with pytest.raises(ValueError):
426+
calibration_curve(y_true2, y_pred2, strategy='percentile')
426427

427428

428429
@pytest.mark.parametrize('ensemble', [True, False])

‎sklearn/tests/test_check_build.py

Copy file name to clipboardExpand all lines: sklearn/tests/test_check_build.py
+4-3Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,11 @@
55
# Author: G Varoquaux
66
# License: BSD 3 clause
77

8-
from sklearn.__check_build import raise_build_error
8+
import pytest
99

10-
from sklearn.utils._testing import assert_raises
10+
from sklearn.__check_build import raise_build_error
1111

1212

1313
def test_raise_build_error():
14-
assert_raises(ImportError, raise_build_error, ImportError())
14+
with pytest.raises(ImportError):
15+
raise_build_error(ImportError())

‎sklearn/tests/test_metaestimators.py

Copy file name to clipboardExpand all lines: sklearn/tests/test_metaestimators.py
+6-6Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
import functools
33

44
import numpy as np
5+
import pytest
56

67
from sklearn.base import BaseEstimator
78
from sklearn.datasets import make_classification
89

9-
from sklearn.utils._testing import assert_raises
1010
from sklearn.utils.validation import check_is_fitted
1111
from sklearn.pipeline import Pipeline
1212
from sklearn.model_selection import GridSearchCV, RandomizedSearchCV
@@ -124,12 +124,12 @@ def score(self, X, y, *args, **kwargs):
124124
% (delegator_data.name, method))
125125
# delegation before fit raises a NotFittedError
126126
if method == 'score':
127-
assert_raises(NotFittedError, getattr(delegator, method),
128-
delegator_data.fit_args[0],
129-
delegator_data.fit_args[1])
127+
with pytest.raises(NotFittedError):
128+
getattr(delegator, method)(delegator_data.fit_args[0],
129+
delegator_data.fit_args[1])
130130
else:
131-
assert_raises(NotFittedError, getattr(delegator, method),
132-
delegator_data.fit_args[0])
131+
with pytest.raises(NotFittedError):
132+
getattr(delegator, method)(delegator_data.fit_args[0])
133133

134134
delegator.fit(*delegator_data.fit_args)
135135
for method in methods:

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.