Feat/adding weather api #193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix for issue schachmat#170 Co-authored-by: Pedro Pereira <pedro.1.pereira@nokia.com>
Current openweather api usage does not have daily astronomy. Api "onecall" seems to have. Co-authored-by: Pedro Pereira <pedro.1.pereira@nokia.com>
compacts the table and hides cloud icons
kordianbruck
reviewed
Oct 6, 2024
Collaborator
kordianbruck
left a comment
There was a problem hiding this comment.
Looks great, just tiny changes please!
…PI' into feat/addingWeatherAPI
Author
|
Your changes are done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Added backend for weatherapi.com
Fixes #158
Description
Code follows the same structure as the other backends, Almost same methods are used to get and modify the data from the API.
Has support for different languages and num of days as well.
Steps for Testing
lat,long)wego london 4Screenshots