Support Keras 2.2.2 and URL requirements #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to work around recent Keras version that has a cyclic dependency. keras-team/keras#10505
pip requirements.txt format allows specifying requirements via absolute network URLs, in addition to package==version syntax. If that syntax is detected in requirements.txt, we pass the url along to the bazel rules, so that the wheel will be pulled from the URL instead of using "pip wheel package==version" command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keras 2.2.2 has cyclic dependencies (keras-team/keras#10505).
Add hacky "remove_runtime_deps" attribute to pip_import to allow breaking such cyclic dependencies.
Also detect https://url/to/package.whl syntax in requriements.txt, and pass the URL over to bazel.
This can speed up iteration cycle for custom-built external wheels that are not hosted on any
pypi index server.