handle None-indexes #273
Closed
handle None-indexes #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some pptx files (possible due to them being created on google slides and then exported to pptx) images do not have the idx set (as they're part of a layout?)
Author
|
I see this is a duplicate of #190 |
Owner
|
@pterk I'm going to leave this one open if that's okay. This shows exactly how to fix it and I like the approach; I think it's the most sensible "compensation" for the invalid XML, it definitely won't make the XML any worse :) I'm going to try to get this into the next release, should have one going in sometime in the next couple weeks. |
Author
|
Definitely okay ;-) Thanks again for the nice software! |
Owner
|
This is fixed in release v0.6.6. |
scanny
added a commit
that referenced
this pull request
Jun 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In some pptx files (possible due to them being created on google slides and then exported to pptx) images do not have the idx set (as they're part of a layout?)
PR - Merge Checklist:
-- Verify: