Fix null characters in binary plists#329
Open
dnicolson wants to merge 1 commit intosbarex:mastersbarex/SourceCodeSyntaxHighlight:masterfrom
Open
Fix null characters in binary plists#329dnicolson wants to merge 1 commit intosbarex:mastersbarex/SourceCodeSyntaxHighlight:masterfrom
dnicolson wants to merge 1 commit intosbarex:mastersbarex/SourceCodeSyntaxHighlight:masterfrom
Conversation
Owner
|
But is it a normal/frequent condition for there to be null characters? Can you attach me a plist with that problem? |
Contributor
Author
|
Not frequently, but I have encountered control characters in binary plist files, presumably when unfiltered text is stored in string fields. In that instance, it broke some text editors (now fixed) when trying to decode the binary into XML. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents null characters from terminating lines when converting binary plist files to XML.
Before:
After: