Improve cmake packaging #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…collector Fix bug in argumentscollector.
Use rand() instead of QRandomGenerator for performance reasons
SFTP upload directory make append dir path optional
Improve CMake buildsystem; fix typo
xakod
reviewed
Nov 18, 2022
| # cached variables | ||
| set(QSSH_BUILD_EXAMPLES True CACHE BOOL "Build the QSsh examples.") | ||
| set(BUILD_SHARED_LIBS False CACHE BOOL "Build QSsh using shared libraries.") | ||
| set(BOTAN_INCLUDE_DIR "" CACHE PATH "Path of the Botan include directory. Set this if user specified BOTAN_LIBRARY location is used.") |
Author
There was a problem hiding this comment.
Last time I checked Botan-2 does not provide .cmake files for finding package. So if I build Botan-2 manually I need a way to point QSsh to the version I have built.
There was a problem hiding this comment.
You can provide your own Findbotan.cmake (example https://stackoverflow.com/a/72323666). botan is a thirdparty library so it should not be in main cmakelists
Author
There was a problem hiding this comment.
Great idea! Could be done in a separate MR though, this one is already changing a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.