Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Refactor GHContentSearchBuilder to allow a Fork type (#1154) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

sahansera
Copy link
Owner

@sahansera sahansera commented Dec 5, 2021

Description

See original PR here.

This PR was created to show the changes I made in order to fix 1154

Changes

  • Introduce a new enum GHFork.
  • Refactor the existing code to use the new GHFork enum.
  • Add a new unit test to test GitHub code search including results of forks.
  • Gracefully deprecate old methods.
  • Add WireMock files for the unit test.

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@sahansera sahansera changed the title Refactor search forks 2 Refactor GHContentSearchBuilder to allow a Fork type Dec 5, 2021
@sahansera sahansera changed the title Refactor GHContentSearchBuilder to allow a Fork type Refactor GHContentSearchBuilder to allow a Fork type (#1154) Dec 5, 2021
@sahansera sahansera closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.