Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Refactor GHContentSearchBuilder to allow a Fork type #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 23, 2021

Conversation

sahansera
Copy link
Owner

@sahansera sahansera commented Nov 18, 2021

Description

Update: I have submitted the PR here: hub4j#1315


This PR includes the following changes:

  • Introduce a new enum GHFork.
  • Refactor the existing code to use the new GHFork enum.
  • Add a new unit test to test GitHub code search including results of forks.

What's pending?

  • Run WireMock snapshots for the newly added unit test

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@sahansera sahansera changed the title Refactor search forks Refactor GHContentSearchBuilder to allow a Fork type Nov 20, 2021
@sahansera sahansera merged commit 7df326e into main Nov 23, 2021
@sahansera sahansera deleted the refactor-search-forks branch June 25, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.