Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

slisaasquatch
Copy link
Collaborator

@slisaasquatch slisaasquatch commented Apr 24, 2023

Description of the change

Changed

  • Switched to Gradle.
  • Added support for JSON Schema draft 2019-09 and 2020-12.
  • Internal dependency version bumps.
  • Test suite cleanup.

Fixed

  • Fixed the time format inference in FormatInferrers.dateTime() to better adhere to the JSON Schema standard. It is trivial to restore the original behavior with a custom implementation of FormatInferrer.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

Copy link
Member

@johanventer johanventer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Please add a CHANGELOG, and do some PR hygiene by adding a name and description for the PR.

@slisaasquatch slisaasquatch changed the title dev 0.2.0 Apr 24, 2023
@slisaasquatch slisaasquatch merged commit 6e6d55e into master Apr 24, 2023
@slisaasquatch slisaasquatch deleted the gradle-dev branch April 26, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.