Fix CMakeLists.txt install paths#73
Merged
ryanhaining merged 1 commit intoryanhaining:masterryanhaining/cppitertools:masterfrom Apr 21, 2020
strega-nil:fix-cmakelistsCopy head branch name to clipboard
Merged
Fix CMakeLists.txt install paths#73ryanhaining merged 1 commit intoryanhaining:masterryanhaining/cppitertools:masterfrom strega-nil:fix-cmakelistsCopy head branch name to clipboard
ryanhaining merged 1 commit intoryanhaining:masterryanhaining/cppitertools:masterfrom
strega-nil:fix-cmakelistsCopy head branch name to clipboard
Conversation
The old code defaulted the cmake config install paths to
share/cppitertools/cmake/cppitertools
whereas CMake expects the config install directory to be one of
(simplifying):
share/cmake/cppitertools
share/cppitertools
share/cppitertools/cmake
Unfortunately, the existing code chose to put `cppitertools` at the end
of the install path unconditionally, and so we're left with either
`share/cppitertools`, or `share/cmake/cppitertools` as options.
Since other projects seemed to choose `share/${PROJECT_NAME}`, I figured
that was a fine option, as long as the default is not broken. Therefore,
this changes the default to
share/cppitertools
Additionally, the old code didn't unconditionally put `cppitertools` at
the end of the config.version file, and so that was never being picked
up. Since it was unlikely that anyone was depending on the
config.version file being installed in the wrong location, we now
install it at the same place as the config file.
Contributor
Author
|
@ryanhaining could you rerun the failing test? |
Owner
|
done. Thank you! I will merge tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old code defaulted the cmake config install paths to
share/cppitertools/cmake/cppitertools
whereas CMake expects the config install directory to be one of
(simplifying):
share/cmake/cppitertools
share/cppitertools
share/cppitertools/cmake
Unfortunately, the existing code chose to put
cppitertoolsat the endof the install path unconditionally, and so we're left with either
share/cppitertools, orshare/cmake/cppitertoolsas options.Since other projects seemed to choose
share/${PROJECT_NAME}, I figuredthat was a fine option, as long as the default is not broken. Therefore,
this changes the default to
share/cppitertools
Additionally, the old code didn't unconditionally put
cppitertoolsatthe end of the config.version file, and so that was never being picked
up. Since it was unlikely that anyone was depending on the
config.version file being installed in the wrong location, we now
install it at the same place as the config file.
Fixes #72