Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: migrate to standalone project config #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 13, 2021
Merged

chore: migrate to standalone project config #977

merged 4 commits into from
Oct 13, 2021

Conversation

exequiel09
Copy link
Contributor

Description

Closes #971

This PR addresses the goal to move to per project configuration introduced in Nx 12.5. It uses the command mentioned in the issue.

nx generate @nrwl/workspace:convert-to-nx-project --all

PR #974 got closed when tried to rename the branch via GitHub web UI 🤷‍♂️

@github-actions github-actions bot added </> Template @rx-angular/template related { } State @rx-angular/state related 🛠️ CDK CDK related labels Oct 9, 2021
@exequiel09 exequiel09 mentioned this pull request Oct 9, 2021
Closed
@exequiel09
Copy link
Contributor Author

@edbzn I think there's something wrong with the CI. I forked this repo and made the branch there and created a PR from my forked repo's branch to this repo. The usual way.

@exequiel09
Copy link
Contributor Author

Like this PR #678 , the check fails: https://github.com/rx-angular/rx-angular/pull/678/checks?check_run_id=3400464026

@exequiel09
Copy link
Contributor Author

I think this one

rx-angular/.github/workflows/build-and-test.yml

Line 65 in 8df99ea

ref: ${{ github.event.pull_request.head.ref }}
works only if you have a branch directly on this repo not on a forked branch? 🤔

I think this one should use github.ref or $GITHUB_REF env var 😅

@exequiel09
Copy link
Contributor Author

exequiel09 commented Oct 10, 2021 •
edited
Loading

Moved the CI issue discussion to #979

@nx-cloud
Copy link

nx-cloud bot commented Oct 12, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 4d1b9d6. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected:build --with-deps
#000000 nx run ssr-e2e:e2e --headless
#000000 nx affected:test --parallel --maxParallel=2
#000000 nx affected:lint --parallel --maxParallel=3

Sent with 💌 from NxCloud.

@exequiel09
Copy link
Contributor Author

@hoebbelsB merged latest master

@exequiel09
Copy link
Contributor Author

Hi @edbzn! can we add hacktoberfest-accepted label here if it's ready for merging? Thanks! 🙏

@hoebbelsB hoebbelsB merged commit 91b8626 into rx-angular:master Oct 13, 2021
@exequiel09 exequiel09 deleted the nx-standalone-proj-config branch October 13, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbzn edbzn edbzn approved these changes

Assignees
No one assigned
Labels
🛠️ CDK CDK related hacktoberfest-accepted { } State @rx-angular/state related </> Template @rx-angular/template related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: migrate to standalone project config
3 participants
@exequiel09 @edbzn @hoebbelsB
Morty Proxy This is a proxified and sanitized view of the page, visit original site.