feat(template): make virtual views not set a height by default #1849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit a356749.
☁️ Nx Cloud last updated this comment at |
hoebbelsB
reviewed
Jan 28, 2025
Comment on lines
+94
to
+101
| You can use the `--rx-vw-h` and `--rx-vw-w` CSS variables in order to define the placeholder dimensions after the virtual view is rendered at least once. | ||
|
|
||
| ```html | ||
| <div style="min-height: var(--rx-vw-h, 100px); min-width: var(--rx-vw-w, 50px);"></div> | ||
| ``` | ||
|
|
||
| If the virtual view is not rendered at least once, the 100px and 50px values will be used as fallback the first time, and after that, the values will be updated to the actual dimensions of the virtual view. | ||
|
|
There was a problem hiding this comment.
maybe this deserves its own headline
hoebbelsB
reviewed
Jan 28, 2025
| RxVirtualViewObserver, | ||
| RxVirtualViewPlaceholder, | ||
| } from '@rx-angular/template/virtual-view'; | ||
| import { RxVirtualView, RxVirtualViewContent, RxVirtualViewObserver, RxVirtualViewPlaceholder } from '@rx-angular/template/virtual-view'; |
|
@eneajaho can we finalize this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.