Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

refactor(state): use DestroyRef instead of OnDestroy life cycle hook #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hoebbelsB merged 1 commit into from
Jan 8, 2025
Merged

refactor(state): use DestroyRef instead of OnDestroy life cycle hook #1829

hoebbelsB merged 1 commit into from
Jan 8, 2025

Conversation

@michaelbe812
Copy link
Contributor

@michaelbe812 michaelbe812 commented Jan 3, 2025

Use DestroyRef within RxActionFactory instead of OnDestroy life cycle hook

@github-actions github-actions bot added the { } State @rx-angular/state related label Jan 3, 2025
@nx-cloud
Copy link

nx-cloud bot commented Jan 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 6005533.

Command Status Duration Result
nx affected -t lint build test component-test e... ✅ Succeeded 39s View ↗
nx build docs ✅ Succeeded 32s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-07 08:01:14 UTC

@michaelbe812 michaelbe812 force-pushed the f/use-destroy-ref-within-rx-action-factory branch from b14ac65 to 3fef130 Compare January 3, 2025 19:17
michaelbe812
michaelbe812 commented Jan 3, 2025
View reviewed changes
libs/state/actions/src/lib/actions.factory.ts Show resolved Hide resolved
JeanMeche
JeanMeche reviewed Jan 6, 2025
View reviewed changes
libs/state/actions/src/lib/actions.factory.ts Outdated Show resolved Hide resolved
@michaelbe812 michaelbe812 force-pushed the f/use-destroy-ref-within-rx-action-factory branch from 3fef130 to 6005533 Compare January 6, 2025 04:52
@michaelbe812
Copy link
Contributor Author

michaelbe812 commented Jan 7, 2025

Same comment here regarding CI
CI fails bc of a 429 to url https://medium.com/itnext/incremental-static-regeneration-for-angular-42b0a8440e53
Probably it is enough to just re run it (locally everything is fine)
However it seems like I do not have the rights to restart the Pipeline

@hoebbelsB hoebbelsB merged commit fa0fdfa into rx-angular:main Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoebbelsB hoebbelsB hoebbelsB approved these changes

@edbzn edbzn edbzn approved these changes

+1 more reviewer

@JeanMeche JeanMeche JeanMeche left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

{ } State @rx-angular/state related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michaelbe812 @JeanMeche @hoebbelsB @edbzn
Morty Proxy This is a proxified and sanitized view of the page, visit original site.