-
-
Notifications
You must be signed in to change notification settings - Fork 204
feat: reintroduce smosh, add docs to selections #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0b1bda8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need this smosh
operator to reduce the number of view subscriptions!
Co-authored-by: push-based-bot <95690470+push-based-bot@users.noreply.github.com>
Co-authored-by: push-based-bot <95690470+push-based-bot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think @BioPhoton about moving the second parameter to the third named parameter, for instance, it's easier this way:
smosh(
{
prop1: cold('h-h-i-i-i-i-i', { h, i }),
prop2: cold('_-a-a-_-b-_-b', { _, a, b }),
prop3: cold('f-f-f-f-f-t-t', { f, t }),
},
undefined, // having to pass undefined or [] is not intuitive
{ durationSelector: cold('s') }
);
smosh(
{
prop1: cold('h-h-i-i-i-i-i', { h, i }),
prop2: cold('_-a-a-_-b-_-b', { _, a, b }),
prop3: cold('f-f-f-f-f-t-t', { f, t }),
},
{ durationSelector: cold('s') }
);
smosh(
{
prop1: cold('h-h-i-i-i-i-i', { h, i }),
prop2: cold('_-a-a-_-b-_-b', { _, a, b }),
prop3: cold('f-f-f-f-f-t-t', { f, t }),
},
{ durationSelector: cold('s'), spreads: [prop$] }
);
I like it @edbzn! |
No description provided.