Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Error logging in hold streams #661

Copy link
Copy link
Open
@d-stolyar

Description

@d-stolyar
Issue body actions

Description

Errors in hold streams are not logged

Steps to Reproduce the Issue

Check stackblitz example

this.hold(
  of(null).pipe(switchMap(() => throwError("error"))),
  value => {
    console.log(value);
  }
);

Result in console:

Expected result in console:
error

Solution

Add console.error in hold definition

hold<S>(
  obsOrObsWithSideEffect: Observable<S>,
  sideEffectFn?: (arg: S) => void
): void {
  const sideEffect = obsOrObsWithSideEffect.pipe(catchError(e => {
    console.error(e)
    return EMPTY
  }))
  if (typeof sideEffectFn === 'function') {
    this.effectObservable.nextEffectObservable(
      sideEffect.pipe(tap(sideEffectFn))
    );
    return;
  }
  this.effectObservable.nextEffectObservable(sideEffect);
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.