Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

ISR: Render behaves differently between render / regenerate / invalidate #1758

Copy link
Copy link
Closed
@maxisam

Description

@maxisam
Issue body actions

Description

only render has feature for modifyGeneratedHtml, it is missing from the other two

I think the issue here is we should consolidate the render function a bit more.

also with modifyGeneratedHtml, I think there is no need for cacheMsg in InMemoryCacheHandler

We can have a default modifyGeneratedHtml function just like cacheMsg

Notes

I will try to fix this in my fork, if you like the proposed solution, I will make a PR.

Sorry making a bunch of changes in a short time, I am trying to port our existing feature to this library. My goal is trying to match the upstream as much as possible.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.